Fix parsing of async in for-of loops
#3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
Fixed tests (1): |
jedel1043
approved these changes
Mar 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
raskad
force-pushed
the
fix-for-of-async-var
branch
from
a6391e3
to
4f84d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a syntax error in for-of loops.
Currently the lookahead for the pattern
async ofin a for-of loop errors also in normal for loops. In a normal for loop this pattern might also be an async arrow function. To fix this I also had to fix the parsing of async arrow functions to allowofas a binding identifier. I added a test for that, since there seems to be no 262 test.