Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing environment creation in initial iteration of for loop #3751

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add missing environment creation in initial iteration of for loop #3751

merged 1 commit into from
Mar 25, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 19, 2024

This Pull Request changes the following:

  • Add missing environment creation in initial iteration of for loop

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Mar 19, 2024
@raskad raskad added this to the v0.18.1 milestone Mar 19, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,775 42,776 +1
Ignored 1,391 1,391 0
Failed 6,102 6,101 -1
Panics 0 0 0
Conformance 85.09% 85.10% +0.00%
Fixed tests (1): 
test/language/statements/for/scope-body-lex-open.js (previously Failed)

@raskad raskad requested a review from a team March 19, 2024 02:32
jedel1043
jedel1043 approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jedel1043 jedel1043 requested a review from a team March 24, 2024 05:43
@jedel1043 jedel1043 added the waiting-on-review Waiting on reviews from the maintainers label Mar 24, 2024
@nekevss nekevss added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 7987fd8 Mar 25, 2024
13 checks passed
@jedel1043 jedel1043 deleted the fix-for-loop-environments branch March 25, 2024 02:21
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @nekevss