Add a try_from_js implementation for Vec<T> (accept any Array-like) #3755
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3755 +/- ##
==========================================
+ Coverage 47.24% 47.80% +0.56%
==========================================
Files 476 454 -22
Lines 46892 44594 -2298
==========================================
- Hits 22154 21319 -835
+ Misses 24738 23275 -1463 ☔ View full report in Codecov by Sentry. |
|
The only concern here would be on how to implement this for TypedArrays, which should have a much faster conversion. Not sure if we would need to specialize or we could just add another branch. |
I suggest a specialized type, like |
| @@ -250,3 +283,42 @@ impl TryFromJs for u128 { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn value_into_vec() { | |||
There was a problem hiding this comment.
nit: can you add a test or two for a failing cases as well?
There was a problem hiding this comment.
Done. What could I do to unblock this? It's blocking some of my follow work that I'd like to submit.
This PR adds an implementation of
TryFromJsforVec<T: TryFromJs>to create Rust vectors from Array-like JavaScript objects.This is useful when using typed arguments to native functions with arrays.