Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an embed_module!() macro to boa_interop #3784

Merged
merged 22 commits into from
Apr 18, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Apr 2, 2024

The macro creates a ModuleLoader that includes all JS files from a directory.

The macro creates a ModuleLoader that includes all JS files from a directory.
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 32.97872% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 50.26%. Comparing base (6ddc2b4) to head (3eb5eeb).
Report is 137 commits behind head on main.

❗ Current head 3eb5eeb differs from pull request most recent head f2ba245. Consider uploading reports for the commit f2ba245 to get more accurate results

Files Patch % Lines
core/macros/src/embedded_module_loader.rs 0.00% 49 Missing ⚠️
core/interop/src/loaders/embedded.rs 70.00% 12 Missing ⚠️
core/macros/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3784      +/-   ##
==========================================
+ Coverage   47.24%   50.26%   +3.01%     
==========================================
  Files         476      461      -15     
  Lines       46892    45058    -1834     
==========================================
+ Hits        22154    22647     +493     
+ Misses      24738    22411    -2327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansl hansl marked this pull request as ready for review April 9, 2024 18:34
@hansl
Copy link
Contributor Author

hansl commented Apr 13, 2024

@jedel1043 this would be ready for review. My use case for this is to have a build process which uses parcel, then embedding the resulting dist folder in the executable.

@hansl hansl requested a review from jedel1043 April 15, 2024 22:20
@hansl hansl requested a review from jedel1043 April 17, 2024 16:51
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs to appease clippy.

@jedel1043 jedel1043 requested a review from a team April 17, 2024 17:08
@jedel1043 jedel1043 added enhancement New feature or request API labels Apr 17, 2024
@jedel1043 jedel1043 added this to the v0.18.1 milestone Apr 17, 2024
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jedel1043 jedel1043 added this pull request to the merge queue Apr 18, 2024
Merged via the queue into boa-dev:main with commit 5a4d977 Apr 18, 2024
13 checks passed
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants