Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryFromJs for Either<L, R> #3822

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Implement TryFromJs for Either<L, R> #3822

merged 2 commits into from
Apr 26, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Apr 21, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 50.27%. Comparing base (6ddc2b4) to head (d6e8e27).
Report is 146 commits behind head on main.

Files Patch % Lines
core/engine/src/value/conversions/either.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3822      +/-   ##
==========================================
+ Coverage   47.24%   50.27%   +3.03%     
==========================================
  Files         476      462      -14     
  Lines       46892    45076    -1816     
==========================================
+ Hits        22154    22664     +510     
+ Misses      24738    22412    -2326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jedel1043
jedel1043 requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

core/engine/Cargo.toml Show resolved Hide resolved
@hansl hansl requested a review from jedel1043 April 26, 2024 17:49
HalidOdat
HalidOdat approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Apr 26, 2024
Merged via the queue into boa-dev:main with commit 6156768 Apr 26, 2024
14 checks passed
@hansl hansl deleted the try_from_js_either branch April 27, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansl @HalidOdat @jedel1043