Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from actions-rs/toolchain to dtolnay/rust-toolchain #3845

Merged
merged 1 commit into from
May 10, 2024
Merged

Switch from actions-rs/toolchain to dtolnay/rust-toolchain #3845

merged 1 commit into from
May 10, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented May 10, 2024 •
edited
Loading

Fix the current ci errors

@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,731 50,731 0
Passed 42,973 42,973 0
Ignored 1,395 1,395 0
Failed 6,363 6,363 0
Panics 18 18 0
Conformance 84.71% 84.71% 0.00%

@raskad raskad marked this pull request as ready for review May 10, 2024 22:10
@raskad raskad added the github_actions Pull requests that update Github_actions code label May 10, 2024
@raskad raskad requested a review from a team May 10, 2024 22:11
nekevss
nekevss approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. actions-rs is archived anyways too, right? So this is probably a good switch regardless of the current CI issues.

@nekevss nekevss requested a review from a team May 10, 2024 22:20
@raskad
Copy link
Member Author

raskad commented May 10, 2024

Sounds good to me. actions-rs is archived anyways too, right? So this is probably a good switch regardless of the current CI issues.

Yes. I will switch the other remaining action-rs actions in a follow up.

@jedel1043 jedel1043 added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 09c08c5 May 10, 2024
13 checks passed
@HalidOdat HalidOdat deleted the fix-ci branch May 11, 2024 01:39
@nekevss nekevss mentioned this pull request May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @nekevss