Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ICU4X to 1.5 and cleanup Intl #3868

Merged
merged 1 commit into from
May 29, 2024
Merged

Bump ICU4X to 1.5 and cleanup Intl #3868

merged 1 commit into from
May 29, 2024

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented May 29, 2024

Some additional cleanups were made to the Intl services, since the ECMA-402 spec had editorial changes that hadn't been implemented.

Had to pin temporal_rs to the git repo until we publish a new version, but it would be better to fix the panics before doing so.

Removed some hacks that we had in place for locale resolution. We still have a small hack for Segmenter, but that will possibly be resolved in the future with locale-aware segmenters.

@jedel1043 jedel1043 added dependencies Pull requests that update a dependency file Intl Changes related to the `Intl` implementation labels May 29, 2024
@jedel1043 jedel1043 added this to the v0.18.1 milestone May 29, 2024
@jedel1043 jedel1043 requested a review from a team May 29, 2024 07:21
Copy link

github-actions bot commented May 29, 2024

Test262 conformance changes

Test result main count PR count difference
Total 50,731 50,771 +40
Passed 42,973 42,985 +12
Ignored 1,395 1,411 +16
Failed 6,363 6,375 +12
Panics 18 19 +1
Conformance 84.71% 84.66% -0.04%
Fixed tests (17):
test/intl402/Segmenter/constructor/supportedLocalesOf/basic.js (previously Failed)
test/intl402/Segmenter/constructor/constructor/locales-valid.js (previously Failed)
test/intl402/Locale/likely-subtags-grandfathered.js (previously Failed)
test/intl402/Collator/supportedLocalesOf/basic.js (previously Failed)
test/intl402/ListFormat/prototype/resolvedOptions/type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/daysInMonth/basic.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/plain-date.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/plain-date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/string.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/basic.js (previously Failed)
test/built-ins/Object/groupBy/string.js (previously Failed)
test/built-ins/Map/groupBy/string.js (previously Failed)
Broken tests (26):
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Unassigned.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Assigned.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Ideographic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/IDS_Binary_Operator.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/XID_Start.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Common.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Grapheme_Base.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/ID_Start.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Unified_Ideograph.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/ID_Continue.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Han.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Symbol.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Malayalam.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Sharada.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Alphabetic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Common.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/XID_Continue.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Symbol.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Sinhala.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Sentence_Terminal.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Other.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Han.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_ZWJ_Sequence.js (previously Passed)

@nekevss
Copy link
Member

nekevss commented May 29, 2024

Using the git repo makes sense to me. And may end up being a nice to work with for development purposes for the next little bit with all the changes coming down the pipeline to the proposal and the library (thinking the parser, duration rounding, the proposal changes).

We may want to just make sure to run a release for temporal_rs and move from the git repo to that release (EDIT: before the next boa release).

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Check the comment if makes sense :)

Cargo.toml Outdated Show resolved Hide resolved
@jedel1043
Copy link
Member Author

jedel1043 commented May 29, 2024

Managed to fix all the Intl regressions. The remaining regressions are caused by new test changes for RegExp with CLDR 15.1

cc @raskad

@raskad
Copy link
Member

raskad commented May 29, 2024

The remaining regressions are caused by new test changes for RegExp with CLDR 15.1

I will look into updating regress with 15.1 :)

test262_config.toml Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 8c727f6 May 29, 2024
13 checks passed
@jedel1043 jedel1043 deleted the icu4x-1_5 branch May 29, 2024 18:56
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Intl Changes related to the `Intl` implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants