Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hashbang comments by using proper goal symbols #3876

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Fix hashbang comments by using proper goal symbols #3876

merged 1 commit into from
Jun 15, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 14, 2024

This Pull Request changes the following:

  • Add a lexer goal symbol for hashbang comments and regexes. This goal is only used for the first lexical token of a Script or Module parse goal.

@raskad raskad added bug Something isn't working lexer Issues surrounding the lexer labels Jun 14, 2024
@raskad raskad added this to the v0.18.1 milestone Jun 14, 2024
@raskad raskad requested a review from a team June 14, 2024 22:26
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,771 50,771 0
Passed 43,014 43,015 +1
Ignored 1,411 1,411 0
Failed 6,346 6,345 -1
Panics 19 19 0
Conformance 84.72% 84.72% +0.00%
Fixed tests (1): 
test/language/comments/hashbang/function-constructor.js (previously Failed)

jedel1043
jedel1043 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pretty happy to follow the spec a bit more closely in this case.

@jedel1043 jedel1043 requested a review from a team June 15, 2024 01:13
@nekevss nekevss added this pull request to the merge queue Jun 15, 2024
Merged via the queue into main with commit 1eaf923 Jun 15, 2024
13 checks passed
@jedel1043 jedel1043 deleted the fix-hashbang-goal branch June 15, 2024 04:27
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lexer Issues surrounding the lexer
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @nekevss