Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some environment clones #3884

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Remove some environment clones #3884

merged 1 commit into from
Jun 30, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 30, 2024

This PR removes some unnecessary clones in environment functions.

@raskad raskad added performance Performance related changes and issues execution Issues or PRs related to code execution labels Jun 30, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,213 50,213 0
Passed 42,981 42,981 0
Ignored 1,411 1,411 0
Failed 5,821 5,821 0
Panics 0 0 0
Conformance 85.60% 85.60% 0.00%

@raskad raskad added this pull request to the merge queue Jun 30, 2024
Merged via the queue into main with commit eb43955 Jun 30, 2024
13 checks passed
@raskad raskad deleted the remove-clones branch July 1, 2024 11:35
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
execution Issues or PRs related to code execution performance Performance related changes and issues
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jasonwilliams @jedel1043