-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustyline for the cli #492
Conversation
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 68.19% 68.19%
=======================================
Files 172 172
Lines 10573 10573
=======================================
Hits 7210 7210
Misses 3363 3363
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good. I have a couple of questions though. Should we use a history file for the console? And, should we print errors in red, for instance?
If you are wondering whether we should have a history feature for the REPL in the first place, maybe for now it could be an optional feature with conditional compilation? |
This PR addresses #464