Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustyline for the cli #492

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Conversation

IovoslavIovchev
Copy link
Contributor

This PR addresses #464

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   68.19%   68.19%           
=======================================
  Files         172      172           
  Lines       10573    10573           
=======================================
  Hits         7210     7210           
  Misses       3363     3363           
Impacted Files Coverage Δ
boa_cli/src/main.rs 33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe591b...63c0798. Read the comment docs.

@HalidOdat HalidOdat added cli Issues and PRs related to the Boa command line interface. enhancement New feature or request labels Jun 15, 2020
@HalidOdat HalidOdat added this to the v0.9.0 milestone Jun 15, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. I have a couple of questions though. Should we use a history file for the console? And, should we print errors in red, for instance?

boa_cli/src/main.rs Outdated Show resolved Hide resolved
@IovoslavIovchev
Copy link
Contributor Author

This looks very good. I have a couple of questions though. Should we use a history file for the console? And, should we print errors in red, for instance?

If you are wondering whether we should have a history feature for the REPL in the first place, maybe for now it could be an optional feature with conditional compilation?
As for the second question, I think it leads to a broader question - how much UX do we want for the REPL? There are definitely quite a few things that could be added. Maybe we should open a master issue with a checklist or something.

@jasonwilliams jasonwilliams modified the milestones: v0.9.0, v0.10.0 Jun 25, 2020
@Razican Razican merged commit a933ae8 into boa-dev:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Boa command line interface. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants