Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error propagation in Field access #500

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Added error propagation in Field access #500

merged 1 commit into from
Jun 16, 2020

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jun 16, 2020

This Pull Request fixes/closes #482.

It changes the following:

  • mod.rs to_object function call error handling to use ? operator

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #500 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   67.62%   67.65%   +0.02%     
==========================================
  Files         160      160              
  Lines        9836     9832       -4     
==========================================
  Hits         6652     6652              
+ Misses       3184     3180       -4     
Impacted Files Coverage Δ
boa/src/exec/field/mod.rs 100.00% <100.00%> (+26.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fca0c...453a3f9. Read the comment docs.

@Razican Razican added bug Something isn't working execution Issues or PRs related to code execution labels Jun 16, 2020
@Razican Razican added this to the v0.9.0 milestone Jun 16, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks!

@HalidOdat HalidOdat merged commit b43e92a into boa-dev:master Jun 16, 2020
@neeldug neeldug deleted the GetFieldErrorHand branch June 16, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field access should propagate the exception (Err(_))
3 participants