Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builtins - object] Object.create #543

Merged
merged 12 commits into from
Jul 8, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jul 3, 2020

Implements Object.create builtin method

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #543 into master will increase coverage by 0.18%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   68.13%   68.31%   +0.18%     
==========================================
  Files         172      172              
  Lines       10546    10606      +60     
==========================================
+ Hits         7185     7246      +61     
+ Misses       3361     3360       -1     
Impacted Files Coverage Δ
boa/src/builtins/object/mod.rs 36.86% <81.81%> (+3.71%) ⬆️
boa/src/builtins/object/tests.rs 100.00% <100.00%> (ø)
boa/src/builtins/error/mod.rs 33.33% <0.00%> (ø)
boa/src/builtins/number/tests.rs 100.00% <0.00%> (ø)
boa/src/builtins/string/tests.rs 100.00% <0.00%> (ø)
boa/src/builtins/symbol/tests.rs 100.00% <0.00%> (ø)
boa/src/builtins/boolean/tests.rs 100.00% <0.00%> (ø)
boa/src/builtins/array/mod.rs 80.90% <0.00%> (+0.09%) ⬆️
boa/src/builtins/string/mod.rs 37.28% <0.00%> (+0.17%) ⬆️
boa/src/builtins/number/mod.rs 65.48% <0.00%> (+0.30%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e82e7c...c7d3a88. Read the comment docs.

@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Jul 3, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 3, 2020
boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
@croraf croraf requested a review from HalidOdat July 7, 2020 15:35
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost ready to merge :)

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat HalidOdat requested a review from Razican July 7, 2020 17:36
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants