Feature Context
#656
Merged
Feature Context
#656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
force-pushed
the
feature/context
branch
from
05349b1
to
84de6bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
- Coverage 72.48% 71.78% -0.70%
==========================================
Files 198 198
Lines 14181 13852 -329
==========================================
- Hits 10279 9944 -335
- Misses 3902 3908 +6
Continue to review full report at Codecov.
|
Benchmark for 37a978cClick to view benchmark
|
Benchmark for 131ba21Click to view benchmark
|
Benchmark for 22c35e1Click to view benchmark
|
Benchmark for 9881612Click to view benchmark
|
HalidOdat
force-pushed
the
feature/context
branch
from
c78a915
to
7facc31
Compare
Benchmark for 5b4f38aClick to view benchmark
|
HalidOdat
force-pushed
the
feature/context
branch
2 times, most recently
from
b726fdb
to
969dc5d
Compare
|
This is ready for review/merge :) |
Razican
requested review from
Razican,
Lan2u and
jasonwilliams
and removed request for
Razican and
Lan2u
HalidOdat
force-pushed
the
feature/context
branch
2 times, most recently
from
7e1bb78
to
b4dc7f9
Compare
Benchmark for 59c9a92Click to view benchmark
|
Benchmark for 2f08743Click to view benchmark
|
Benchmark for 2950f6fClick to view benchmark
|
Lan2u
approved these changes
Sep 6, 2020
|
Why don't we fix the deprecation warnings as part of this merge request? Actually maybe disregard that, 1k+ warnings :O |
A way that we can remove this is to set them to be |
Benchmark for a7bd429Click to view benchmark
|
HalidOdat
force-pushed
the
feature/context
branch
from
503572a
to
f20fa24
Compare
I think keeping deprecated is best as it describes the situation well |
Benchmark for dca5d59Click to view benchmark
|
It would be much nicer if What do you think? @Lan2u |
Benchmark for 8c496c5Click to view benchmark
|
Yeah, it is a nice solution and to be honest, just having a forward/forward_val/exec which internally uses the new context::exec() is not a bad longer-term solution as to me this is just the same as having a test helper function. |
HalidOdat
force-pushed
the
feature/context
branch
from
5ca5991
to
39ed8f9
Compare
Benchmark for b4738eeClick to view benchmark
|
- Move `Console` to `Context` - Change `Context::global()` to `Context::global_object()` - Remove some `use std::borrow::Borrow` - Add some pub exports - Add `Context::eval()` - Deprecate forward_val, forward, exec - Make boa_cli use Context::eval() - Deprecated forward forward_val and exec - Make deprecated functions only compile in test mode
HalidOdat
force-pushed
the
feature/context
branch
from
39ed8f9
to
c1961de
Compare
Benchmark for 30c88ccClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #445
It changes the following:
Context&mut Context.Context::eval()instead offorward_val,forward,exec.Contextlikesymbol_counttoContext.