Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse error throwing a TypeError, instead of SyntaxError #748

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

iamsaquib8
Copy link
Contributor

This Pull Request fixes/closes #741

It changes the following:

  • eval method will throw syntaxError rather than typeError
  • Adds a test for identifier

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #748 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   71.75%   71.84%   +0.08%     
==========================================
  Files         200      200              
  Lines       13983    13985       +2     
==========================================
+ Hits        10033    10047      +14     
+ Misses       3950     3938      -12     
Impacted Files Coverage Δ
boa/src/context.rs 62.56% <100.00%> (+1.11%) ⬆️
boa/src/exec/tests.rs 100.00% <100.00%> (ø)
tester/src/exec.rs
tester/src/results.rs
tester/src/main.rs
tester/src/read.rs
boa_tester/src/main.rs 0.00% <0.00%> (ø)
boa_tester/src/results.rs 0.00% <0.00%> (ø)
boa_tester/src/read.rs 0.00% <0.00%> (ø)
boa_tester/src/exec.rs 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b13c9d...e83d1ce. Read the comment docs.

@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Oct 1, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Oct 1, 2020
@HalidOdat HalidOdat changed the title changes typeError to syntaxError for eval Fix parse error throwing a TypeError, instead of SyntaxError Oct 1, 2020
@HalidOdat HalidOdat merged commit 2feb72a into boa-dev:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

break = 1; gives Uncaught "TypeError" instead of Uncaught "SyntaxError"
2 participants