Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Object.getOwnPropertyDescriptor() and Object.getOwnPropertyDescriptors() #798

Merged
merged 16 commits into from
Oct 12, 2020

Conversation

JohnDoneth
Copy link
Contributor

It changes the following:

  • Implements Object.getOwnPropertyDescriptor( object, property ) and Object.getOwnPropertyDescriptors( object )

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #798 into master will decrease coverage by 0.07%.
The diff coverage is 73.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   59.37%   59.29%   -0.08%     
==========================================
  Files         157      157              
  Lines       10036    10078      +42     
==========================================
+ Hits         5959     5976      +17     
- Misses       4077     4102      +25     
Impacted Files Coverage Δ
boa/src/builtins/object/mod.rs 64.86% <73.17%> (+3.18%) ⬆️
boa/src/context.rs 61.08% <0.00%> (-6.04%) ⬇️
boa/src/syntax/parser/expression/update.rs 70.96% <0.00%> (-1.76%) ⬇️
boa/src/profiler.rs 0.00% <0.00%> (ø)
boa/src/syntax/ast/node/array/mod.rs 74.07% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82dee1...df015bd. Read the comment docs.

@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Oct 5, 2020
boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 5, 2020
@HalidOdat
Copy link
Member

Hey @JohnDoneth, there is a conflict could you rebase this PR.

boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
@Razican Razican requested a review from Lan2u October 12, 2020 11:29
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Check my comments about the documentation, I think it's best if we use the rolling spec, and we need to fix a link at least.

boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Razican Razican merged commit 3047ed6 into boa-dev:master Oct 12, 2020
@JohnDoneth JohnDoneth deleted the get_own_property_descriptor branch October 12, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants