Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(boa): minor cleanup #838

Merged
merged 4 commits into from
Oct 11, 2020
Merged

style(boa): minor cleanup #838

merged 4 commits into from
Oct 11, 2020

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Oct 10, 2020

It changes the following:

  • extracts return from if let statement
  • fixes clippy error in nightly

- extracts return from if let statement
- fixes clippy error in nightly
- extracts return from if let statement
- fixes clippy error in nightly
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #838 into master will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   59.37%   59.37%           
=======================================
  Files         157      157           
  Lines       10036    10036           
=======================================
  Hits         5959     5959           
  Misses       4077     4077           
Impacted Files Coverage Δ
boa/src/builtins/number/mod.rs 60.56% <50.00%> (ø)
boa/src/builtins/array/mod.rs 72.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82dee1...f3b7544. Read the comment docs.

@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 11, 2020
@Razican Razican merged commit 98deb58 into boa-dev:master Oct 11, 2020
@neeldug neeldug deleted the number-cleanup branch October 11, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants