Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boa context] Minor refactor and rename in eval() method #841

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Oct 10, 2020

Some terms were really wrong, like "parser_expr" or "Ok(expr)".

I also made some opinionated minor modification (like put the private method with one statement inline, and split parsing and execution into two statements).

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #841 into master will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   59.37%   59.36%   -0.02%     
==========================================
  Files         157      157              
  Lines       10036    10035       -1     
==========================================
- Hits         5959     5957       -2     
- Misses       4077     4078       +1     
Impacted Files Coverage Δ
boa/src/context.rs 66.51% <60.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82dee1...243db29. Read the comment docs.

@Lan2u Lan2u merged commit 0c92d37 into boa-dev:master Oct 11, 2020
@RageKnify RageKnify added this to the v0.11.0 milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants