Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more number literals in BigInt's from string constructor #880

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Support more number literals in BigInt's from string constructor #880

merged 1 commit into from
Oct 16, 2020

Conversation

georgeroman
Copy link
Contributor

This fixes the cannot convert to BigInt errors documented in #817.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #880 into master will increase coverage by 0.21%.
The diff coverage is 70.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
+ Coverage   59.08%   59.30%   +0.21%     
==========================================
  Files         164      165       +1     
  Lines       10209    10342     +133     
==========================================
+ Hits         6032     6133     +101     
- Misses       4177     4209      +32     
Impacted Files Coverage Δ
boa/src/builtins/mod.rs 23.52% <ø> (ø)
boa/src/syntax/ast/op.rs 11.23% <ø> (ø)
boa/src/object/mod.rs 46.99% <40.00%> (-0.11%) ⬇️
boa/src/syntax/lexer/number.rs 63.76% <40.00%> (+0.35%) ⬆️
boa/src/builtins/bigint/conversions.rs 76.31% <66.66%> (-5.83%) ⬇️
boa/src/builtins/function/mod.rs 63.47% <66.66%> (+0.37%) ⬆️
boa/src/builtins/map/map_iterator.rs 71.42% <71.42%> (ø)
boa/src/builtins/map/mod.rs 72.26% <80.00%> (+0.95%) ⬆️
boa/src/builtins/array/mod.rs 73.51% <85.18%> (+0.80%) ⬆️
boa/src/builtins/iterable/mod.rs 94.23% <100.00%> (+0.35%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5e888...961fa24. Read the comment docs.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Oct 16, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 16, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! thanks for the contribution :D

@Razican Razican merged commit 0c6bcac into boa-dev:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants