Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enumerable attribute on array length property #972

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Fix enumerable attribute on array length property #972

merged 3 commits into from
Dec 18, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 16, 2020

This Pull Request fixes #971 .

It changes the following:

  • The length property of an array is set to non enumerable

@codecov
Copy link

codecov bot commented Dec 16, 2020 •
edited
Loading

Codecov Report

Merging #972 (636d4e4) into master (b058b2d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #972   +/-   ##
=======================================
  Coverage   59.56%   59.57%           
=======================================
  Files         166      166           
  Lines       10815    10817    +2     
=======================================
+ Hits         6442     6444    +2     
  Misses       4373     4373
Impacted Files Coverage Δ
boa/src/builtins/array/mod.rs 73.47% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b058b2d...b9daa0e. Read the comment docs.

@RageKnify RageKnify added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Dec 16, 2020
@tofpie tofpie mentioned this pull request Dec 16, 2020
Merged
@Razican Razican added this to the v0.11.0 milestone Dec 17, 2020
@Razican
Copy link
Member

Razican commented Dec 17, 2020 •
edited
Loading

Does this fix both cases?

>> Array.prototype.propertyIsEnumerable("length")
false
>> [].propertyIsEnumerable("length")
false

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 19,392 19,396 +4
Ignored 15,585 15,585 0
Failed 43,516 43,512 -4
Panics 447 447 0
Conformance 24.71 24.71 +0.01%

Razican
Razican approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :) thanks

@tofpie
Copy link
Contributor Author

tofpie commented Dec 17, 2020

Not yet, I will add the fix for Array.prototype

@Razican
Copy link
Member

Razican commented Dec 17, 2020

Not yet, I will add the fix for Array.prototype

Yes, please :) that way we fix both

@Razican
Copy link
Member

Razican commented Dec 17, 2020

This is blocked on #977.

@Razican
Copy link
Member

Razican commented Dec 18, 2020

#977 was merged, could you rebase?

@RageKnify RageKnify merged commit b5cf0f0 into boa-dev:master Dec 18, 2020
@tofpie tofpie deleted the fix-971 branch December 18, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@RageKnify RageKnify RageKnify approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Lan2u Lan2u Awaiting requested review from Lan2u

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

The length property of an array is enumerable
3 participants
@tofpie @Razican @RageKnify