Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prototypes for Number, String and Boolean #981

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Fix prototypes for Number, String and Boolean #981

merged 2 commits into from
Dec 20, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 18, 2020

This Pull Request fixes #980.

It changes the following:

  • Prototypes for String, Number and Boolean

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #981 (964eaed) into master (d46080d) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
+ Coverage   59.56%   59.80%   +0.23%     
==========================================
  Files         166      166              
  Lines       10821    10842      +21     
==========================================
+ Hits         6446     6484      +38     
+ Misses       4375     4358      -17     
Impacted Files Coverage Δ
boa/src/context.rs 64.46% <100.00%> (+3.20%) ⬆️
boa/src/object/mod.rs 51.41% <0.00%> (+4.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46080d...1450788. Read the comment docs.

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Dec 18, 2020
@Razican Razican added this to the v0.11.0 milestone Dec 18, 2020
@RageKnify RageKnify merged commit 395a28c into boa-dev:master Dec 20, 2020
@tofpie tofpie deleted the fix-proto branch December 25, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad prototypes for String, Number and Boolean
4 participants