Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Object.prototype.isPrototypeOf #983

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Implement Object.prototype.isPrototypeOf #983

merged 2 commits into from
Dec 21, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 19, 2020

This Pull Request closes #982 .

It changes the following:

  • Implementation of `Object.prototype.isPrototypeOf
  • Fix construct when the prototype of the constructor is not an object

@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #983 (f7c7c0b) into master (880792e) will increase coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
+ Coverage   59.67%   59.74%   +0.06%     
==========================================
  Files         166      166              
  Lines       10813    10830      +17     
==========================================
+ Hits         6453     6470      +17     
  Misses       4360     4360              
Impacted Files Coverage Δ
boa/src/builtins/object/mod.rs 67.66% <69.23%> (+2.72%) ⬆️
boa/src/object/gcobject.rs 64.72% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880792e...1679573. Read the comment docs.

@Razican Razican added this to the v0.11.0 milestone Dec 21, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 19,404 19,481 +77
Ignored 15,585 15,585 0
Failed 43,504 43,427 -77
Panics 447 448 +1
Conformance 24.72 24.82 +0.10%

@Razican Razican merged commit b2dba53 into boa-dev:master Dec 21, 2020
@tofpie tofpie deleted the is-proto-of branch December 21, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Object.prototype.isPrototypeOf
3 participants