Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logical expressions evaluation #999

Merged
merged 2 commits into from
Dec 27, 2020
Merged

Fix logical expressions evaluation #999

merged 2 commits into from
Dec 27, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 26, 2020

This Pull Request fixes/closes #998 .

It changes the following:

  • Evaluation of logical expressions

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #999 (88e173d) into master (015c11e) will decrease coverage by 0.02%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   59.97%   59.95%   -0.03%     
==========================================
  Files         166      166              
  Lines       10851    10857       +6     
==========================================
+ Hits         6508     6509       +1     
- Misses       4343     4348       +5     
Impacted Files Coverage Δ
boa/src/syntax/ast/node/operator/bin_op/mod.rs 71.18% <63.63%> (-2.50%) ⬇️
boa/src/value/display.rs 88.63% <80.00%> (-0.90%) ⬇️
boa/src/value/conversions.rs 59.01% <0.00%> (-3.28%) ⬇️
boa/src/property/mod.rs 53.43% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015c11e...88e173d. Read the comment docs.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two redundant clones that rust-clippy is reporting, and should be fixed, besides that it looks good to me!

@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Dec 26, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Dec 26, 2020
@HalidOdat
Copy link
Member

Test262 conformance results:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 19,596 19,634 +38
Ignored 15,585 15,585 0
Failed 43,312 43,274 -38
Panics 447 430 -17
Conformance 24.97 25.01 +0.05%

@RageKnify RageKnify merged commit f34e0b5 into boa-dev:master Dec 27, 2020
@tofpie tofpie deleted the fix-logical-expr branch December 27, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical expressions always return a boolean value
3 participants