Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved soft key stuff to CHARIO. #216

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Moved soft key stuff to CHARIO. #216

merged 1 commit into from
Dec 11, 2022

Conversation

jgharston
Copy link
Contributor

No description provided.

bobbimanners
bobbimanners approved these changes Dec 11, 2022
View reviewed changes
Copy link
Owner

@bobbimanners bobbimanners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! I am going to change the softswitch writes (WRMAINRAM, WRCARDRAM) to use the macros which also handle disabling of interrupts etc.

@bobbimanners bobbimanners merged commit b06ff0d into bobbimanners:main Dec 11, 2022
@bobbimanners
Copy link
Owner

Thanks Jonathan!

@bobbimanners
Copy link
Owner

@jgharston I merged and did a bit of post-merge cleanup. Please pull to get the latest changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbimanners bobbimanners bobbimanners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgharston @bobbimanners