-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve a little Epic Games Guide and add more Unity Games #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - please see my non-blocking nit. I'd appreciate you fixing this later if you have time and thank you for the changes - great to see them :-)
- [Violett Remastered](#violett-remastered) | ||
|
||
# Breach & Clear | ||
# Games actually running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: want to adjust this to something consistent with the other header ("Games that don't work currently"), e.g. "Games confirmed to work"?
# Breach & Clear | ||
# Games actually running | ||
|
||
### Breach & Clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like that (and other headings below) should be ## for second level, right? The higher level is first level and this is currently third level - we're missing one level here
@@ -1,6 +1,8 @@ | |||
How to get game data from Epic Games | |||
=============================== | |||
|
|||
(Guide originally made by [M0REKZ](https://github.com/M0REKZ), using the Steam one as Base) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd remove the parentheses here
|---------------|:-------------------------------------------------------------| | ||
| Unity version | `5.6.1f1` | | ||
| Installer | `https://download.unity3d.com/download_unity/2860b30f0b54/MacEditorInstaller/Unity-5.6.1f1.pkg` | | ||
| MD5 | `N/A` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I like having MD5s just in case we'd ever need to download from third-party sources. The file you've provided above would be dd14e6a5a9fc4961b4072fe918f6ac97
|---------------|:-------------------------------------------------------------| | ||
| Unity version | `4.5.0f6` | | ||
| Installer | `https://download.unity3d.com/download_unity/unity-4.5.0.dmg` | | ||
| MD5 | `N/A` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above. 81081098c29e235b6db232b3e7aaa0bd
Ok, i sent a new pull request #5 |
Yeah..:
is not much, but im helping at least :P