-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP2 #14
BIP2 #14
Commits on May 1, 2021
-
This format can store an arbitrary number of resolutions of the image in one file. At the moment we're just doing two though, the first one for icons (32x32), the second for images (full size).
Configuration menu - View commit details
-
Copy full SHA for 12e8db0 - Browse repository at this point
Copy the full SHA 12e8db0View commit details
Commits on May 2, 2021
-
I'm not 100% satisfied with this code, but it does work.
Configuration menu - View commit details
-
Copy full SHA for a5f0436 - Browse repository at this point
Copy the full SHA a5f0436View commit details -
Convert example BIP1 files to BIP2
Well actually I converted them from the original JPG / PNG files, but the result is the same.
Configuration menu - View commit details
-
Copy full SHA for 96d9acd - Browse repository at this point
Copy the full SHA 96d9acdView commit details -
Use size instead of (width, height)
I think this is a bit more elegant.
Configuration menu - View commit details
-
Copy full SHA for 2d7bc54 - Browse repository at this point
Copy the full SHA 2d7bc54View commit details -
Adjust loader code for readability
Removed some newlines which I felt didn't belong. Renamed count to length when talking about (width * height), because that's what I call it elsewhere in the code too, and count refers to the amount of images in a BIP file. Updated an assert message that I forgot to update earlier. Changed how the data dictionary is used, so now icon_size and icon_pixels are set on its creation, and only overwritten in if the icon needed resizing.
Configuration menu - View commit details
-
Copy full SHA for b0a853c - Browse repository at this point
Copy the full SHA b0a853cView commit details -
Use size instead of (width, height) for converter
I did the same for the loader and I like to be consistent.
Configuration menu - View commit details
-
Copy full SHA for 9fe8629 - Browse repository at this point
Copy the full SHA 9fe8629View commit details
Commits on May 3, 2021
-
Use length for read in converter
Functionally the same but more explicit.
Configuration menu - View commit details
-
Copy full SHA for 79d2819 - Browse repository at this point
Copy the full SHA 79d2819View commit details -
Add icon example to alpha popup
Just to show that previews can be used as icons now.
Configuration menu - View commit details
-
Copy full SHA for d7c0ee6 - Browse repository at this point
Copy the full SHA d7c0ee6View commit details -
Add comments to explain RGBa conversion
This code is a bit opaque otherwise.
Configuration menu - View commit details
-
Copy full SHA for e6849e0 - Browse repository at this point
Copy the full SHA e6849e0View commit details -
Add asserts to make sure count > 0
Interestingly, the loader seems to support BIP2 files with only one resolution, even though it expects two. I haven't tested it, but just reading the code, that's how it probably works.
Configuration menu - View commit details
-
Copy full SHA for 422b84f - Browse repository at this point
Copy the full SHA 422b84fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 260e769 - Browse repository at this point
Copy the full SHA 260e769View commit details