Ensure pip is installed #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also I changed the structure a little, it now uses early returns. And 'PIL' is now stored as a variable instead of hardcoded in two places. It works fine on my windows machine, but I'd like to see at least one test on linux too.
Now pip should install in the user location, which works without admin. Also I'm adding upgrade to both calls to make sure everything is up to date (otherwise the user would have to manually uninstall things and reinstall them). I split args into command and options because I think the line wrapping looked bad.
Makes more sense to check the result from this function than to call support_pillow afterwards. Also I added some newlines.
So the user can easily update Pillow.
This replaces the checkbox icon on the button.
Install Pillow now makes sure that pip is installed first.
Whoops, for this example we actually want 128x128 images.
We agreed on "This could take a few minutes" (maximum of 20 minutes in the works success case).
coreprocess
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the install button updates Pillow now if it's already installed.
Oh and I scaled the example images down to 128x128, so they don't need to be scaled during load.