Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations #48

Merged
merged 11 commits into from
May 31, 2021
Merged

Optimizations #48

merged 11 commits into from
May 31, 2021

Commits on May 23, 2021

  1. Configuration menu
    Copy the full SHA
    53807b5 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Configuration menu
    Copy the full SHA
    31907fa View commit details
    Browse the repository at this point in the history
  2. Remove debug prints.

    coreprocess committed May 24, 2021
    Configuration menu
    Copy the full SHA
    34973f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4820308 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Add dots to extensions

    And use pathlib to get the suffix.
    I think this approach is cleaner.
    bonjorno7 committed May 31, 2021
    Configuration menu
    Copy the full SHA
    238bf08 View commit details
    Browse the repository at this point in the history
  2. Use early return if file has no extension

    This allows the code after it to be tabbed back, which I prefer.
    Also I changed comments a little.
    bonjorno7 committed May 31, 2021
    Configuration menu
    Copy the full SHA
    a7c4cdc View commit details
    Browse the repository at this point in the history
  3. Add comments to settings.py

    I think it's good to have this documented.
    bonjorno7 committed May 31, 2021
    Configuration menu
    Copy the full SHA
    60effbc View commit details
    Browse the repository at this point in the history
  4. Rename ImagePreviewCollection event to abort_signal

    This makes it more obvious what it's for.
    bonjorno7 committed May 31, 2021
    Configuration menu
    Copy the full SHA
    743dd5c View commit details
    Browse the repository at this point in the history
  5. Tweaks to thread.py

    Adjusted some comments, newlines, formatting.
    We want to catch it if a queue item is somehow not a correct size tuple, so I'm just doing a generic except instead of excepting Empty.
    Variables that end in `sig` now end in `_signal`.
    `_read_thread` no longer takes `thread_index`, as it wasn't using it.
    Swapped the order of the signal check and try block.
    Removed manual unregister of timer, as returning None is enough.
    bonjorno7 committed May 31, 2021
    Configuration menu
    Copy the full SHA
    d88cf73 View commit details
    Browse the repository at this point in the history
  6. Rename thread.py to threads.py

    There are multiple threads.
    All the other files follow a plural naming scheme.
    bonjorno7 committed May 31, 2021
    Configuration menu
    Copy the full SHA
    9f676a9 View commit details
    Browse the repository at this point in the history
  7. Bump version to 1.0.9

    coreprocess committed May 31, 2021
    Configuration menu
    Copy the full SHA
    887f26d View commit details
    Browse the repository at this point in the history