-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations #48
Merged
Merged
Optimizations #48
Commits on May 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 53807b5 - Browse repository at this point
Copy the full SHA 53807b5View commit details
Commits on May 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 31907fa - Browse repository at this point
Copy the full SHA 31907faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34973f1 - Browse repository at this point
Copy the full SHA 34973f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4820308 - Browse repository at this point
Copy the full SHA 4820308View commit details
Commits on May 31, 2021
-
And use pathlib to get the suffix. I think this approach is cleaner.
Configuration menu - View commit details
-
Copy full SHA for 238bf08 - Browse repository at this point
Copy the full SHA 238bf08View commit details -
Use early return if file has no extension
This allows the code after it to be tabbed back, which I prefer. Also I changed comments a little.
Configuration menu - View commit details
-
Copy full SHA for a7c4cdc - Browse repository at this point
Copy the full SHA a7c4cdcView commit details -
I think it's good to have this documented.
Configuration menu - View commit details
-
Copy full SHA for 60effbc - Browse repository at this point
Copy the full SHA 60effbcView commit details -
Rename ImagePreviewCollection event to abort_signal
This makes it more obvious what it's for.
Configuration menu - View commit details
-
Copy full SHA for 743dd5c - Browse repository at this point
Copy the full SHA 743dd5cView commit details -
Adjusted some comments, newlines, formatting. We want to catch it if a queue item is somehow not a correct size tuple, so I'm just doing a generic except instead of excepting Empty. Variables that end in `sig` now end in `_signal`. `_read_thread` no longer takes `thread_index`, as it wasn't using it. Swapped the order of the signal check and try block. Removed manual unregister of timer, as returning None is enough.
Configuration menu - View commit details
-
Copy full SHA for d88cf73 - Browse repository at this point
Copy the full SHA d88cf73View commit details -
Rename thread.py to threads.py
There are multiple threads. All the other files follow a plural naming scheme.
Configuration menu - View commit details
-
Copy full SHA for 9f676a9 - Browse repository at this point
Copy the full SHA 9f676a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 887f26d - Browse repository at this point
Copy the full SHA 887f26dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.