Tx gas should never larger than block limit (paritytech#346)

boolnetwork · Apr 6, 2021 · 63c4a77 · 63c4a77
1 parent c0f073f
commit 63c4a77
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/frame/ethereum/src/lib.rs b/frame/ethereum/src/lib.rs
@@ -181,6 +181,7 @@ enum TransactionValidationError {
 	UnknownError,
 	InvalidChainId,
 	InvalidSignature,
+	InvalidGasLimit,
 }
 
 impl<T: Config> frame_support::unsigned::ValidateUnsigned for Module<T> {
@@ -197,6 +198,10 @@ impl<T: Config> frame_support::unsigned::ValidateUnsigned for Module<T> {
 			let origin = Self::recover_signer(&transaction)
 				.ok_or_else(|| InvalidTransaction::Custom(TransactionValidationError::InvalidSignature as u8))?;
 
+			if transaction.gas_limit >= T::BlockGasLimit::get() {
+				return InvalidTransaction::Custom(TransactionValidationError::InvalidGasLimit as u8).into();
+			}
+
 			let account_data = pallet_evm::Module::<T>::account_basic(&origin);
 
 			if transaction.nonce < account_data.nonce {