Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api client #1

Merged
merged 3 commits into from
Apr 30, 2020
Merged

Api client #1

merged 3 commits into from
Apr 30, 2020

Conversation

acreilly
Copy link
Contributor

No description provided.

dpritchett
dpritchett approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@dpritchett dpritchett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally, the DSL looks nicer than the autogenerated one from my Gem. Let's run with this for now.

@acreilly acreilly merged commit aa67708 into master Apr 30, 2020
@acreilly acreilly deleted the api-client branch April 30, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpritchett dpritchett dpritchett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acreilly @dpritchett