Prevented deletion of clients/projects with associated data, and tested.

Gemfile

@@ -7,6 +7,7 @@ gem 'kaminari'
 
 group :test do
   gem 'shoulda'
+	gem 'factory_girl_rails'
 end
 
 # Bundle gems for the local environment. Make sure to

Gemfile.lock

@@ -32,6 +32,10 @@ GEM
     builder (2.1.2)
     erubis (2.6.6)
       abstract (>= 1.0.0)
+    factory_girl (2.0.2)
+    factory_girl_rails (1.1.0)
+      factory_girl (~> 2.0.0)
+      railties (>= 3.0.0)
     i18n (0.5.0)
     jquery-rails (1.0.12)
       railties (~> 3.0)
@@ -78,6 +82,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  factory_girl_rails
   jquery-rails
   kaminari
   rails (= 3.0.9)

TODO

@@ -1,9 +1,11 @@
-* don't allow deletion of clients/projects if event data exists
-* limit users to one active event or allow parallel (make an option?)
+* handling of unverified request?
+* Github-style page sliding when changing pages?
+* Monthly Report takes up too much width
 
 * indexes on db columns
 * testing/handling for:
 	* events that overlap midnight <- for now apply hours to start day
   * events that overlap a DST-type change (handled automatically?)
 
+* limit users to one active event or allow parallel (make an option?)
 * what about personal projects or projects for small clients with no sub projects? how to make that clean and easy?

app/models/client.rb

@@ -1,5 +1,5 @@
 class Client < ActiveRecord::Base
-  has_many :projects
+  has_many :projects, :dependent => :restrict
   has_many :events, :through => :projects
 
   default_scope order('LOWER(name) ASC')

app/models/project.rb

@@ -1,6 +1,6 @@
 class Project < ActiveRecord::Base
   belongs_to :client
-  has_many :events
+  has_many :events, :dependent => :restrict
   default_scope order('LOWER(title) ASC')
   validates_presence_of :title
 end

test/factories.rb

@@ -0,0 +1,17 @@
+FactoryGirl.define do
+  factory :client do
+    name 'Foo Inc.'
+  end
+
+  factory :project do
+    client
+    title 'Hard Work'
+  end
+
+  factory :event do |f|
+    f.project
+    f.comment 'An event'
+    f.start { 1.hour.ago }
+    f.end { Time.now }
+  end
+end

test/unit/client_test.rb

@@ -3,4 +3,11 @@
 class ClientTest < ActiveSupport::TestCase
   should have_many(:projects)
   should validate_presence_of(:name)
+
+  should 'not be destroyable if there are projects' do
+    project = Factory.create(:project)
+    client = project.client
+    assert_raise(ActiveRecord::DeleteRestrictionError) { client.destroy }
+    assert !client.destroyed?, 'check for !client.destroyed?'
+  end
 end

test/unit/project_test.rb

@@ -4,4 +4,11 @@ class ProjectTest < ActiveSupport::TestCase
   should belong_to(:client)
   should have_many(:events)
   should validate_presence_of(:title)
+
+  should 'not be destroyable if there are events' do
+    event = Factory.create(:event)
+    project = event.project
+    assert_raise(ActiveRecord::DeleteRestrictionError) { project.destroy }
+    assert !project.destroyed?, 'check for !project.destroyed?'
+  end
 end