Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::bind2nd is removed in c++17 #126

Closed
gmoryes opened this issue Aug 16, 2018 · 6 comments
Closed

std::bind2nd is removed in c++17 #126

gmoryes opened this issue Aug 16, 2018 · 6 comments

Comments

@gmoryes
Copy link
Contributor

gmoryes commented Aug 16, 2018

It used here:

  1. include/boost/gil/planar_pixel_iterator.hpp
  2. include/boost/gil/extension/numeric/pixel_numeric_operations.hpp
    It was deprecated in c++17. Could you use std::bind + std::placeholders instead std::bind2nd?

Thanks.

@gmoryes gmoryes changed the title std::bind2nd is deprecated in c++17 std::bind2nd is removed in c++17 Aug 16, 2018
@mloskot
Copy link
Member

mloskot commented Aug 16, 2018

Yes, we are aware.

However, GIL has not switched to C++17 yet. Currently, GIL requires C++11 compiler.

@gmoryes
Copy link
Contributor Author

gmoryes commented Aug 17, 2018

Okey, but the fix consists of 3 line. You still will not do it?
If no - what about pull request?

@mloskot mloskot reopened this Aug 17, 2018
@mloskot
Copy link
Member

mloskot commented Aug 17, 2018

Yes, I know and yes we will do it when we will be switching over to C++17 or when one of us finds time to make such refactoring.

If you wish to see this change in GIL earlier, then please submit pull request. (We would not have this unnecessary discussion if you just sent the PR straight away :-))

@gmoryes
Copy link
Contributor Author

gmoryes commented Aug 17, 2018

Okey. I see :)

@gmoryes
Copy link
Contributor Author

gmoryes commented Aug 17, 2018

#127

@gmoryes gmoryes closed this as completed Aug 27, 2018
@mloskot
Copy link
Member

mloskot commented May 20, 2022

This is included in the planning towards C++14/17 discussion here #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants