Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove std::bind2nd #127

Merged
merged 1 commit into from
Aug 21, 2018
Merged

remove std::bind2nd #127

merged 1 commit into from
Aug 21, 2018

Conversation

gmoryes
Copy link
Contributor

@gmoryes gmoryes commented Aug 17, 2018 •
edited by mloskot
Loading

Fixes #127

@gmoryes gmoryes mentioned this pull request Aug 17, 2018
Closed
mloskot
mloskot approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming Travis CI will be as green as AppVeyor.

Thanks @gmoryes !

@mloskot mloskot requested a review from chhenning August 17, 2018 12:36
@mloskot
Copy link
Member

mloskot commented Aug 17, 2018

It looks we are experiencing delay on Travis CI and we can't do anything about it, I'm afraid. We need to wait.

image

@gmoryes
Copy link
Contributor Author

gmoryes commented Aug 21, 2018

Seems all tests passed, what about merging? :)

@stefanseefeld stefanseefeld merged commit eebe183 into boostorg:master Aug 21, 2018
@stefanseefeld
Copy link
Member

There you go ! :-)
Many thanks !

@stefanseefeld
Copy link
Member

Actually, I just now realize that you sent a PR against master. You should always submit PRs against the develop branch instead. My fault for not catching this earlier. Not a problem for this time, but please remember for future contributions. :-)

@mloskot
Copy link
Member

mloskot commented Aug 21, 2018

Ouch, I should have checked that myself too. Sorry @stefanseefeld !

@gmoryes It's always a good idea to skim https://github.com/boostorg/gil/blob/develop/CONTRIBUTING.md

Regardless if you decide to develop again master (recommended) or develop branch of the Boost super-project, you should always base your work (ie. topic branches) on Boost.GIL develop branch.

@mloskot mloskot added this to the Boost 1.69+ milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

@stefanseefeld stefanseefeld stefanseefeld approved these changes

@chhenning chhenning chhenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Boost 1.69
Development

Successfully merging this pull request may close these issues.
4 participants
@gmoryes @mloskot @stefanseefeld @chhenning