Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gil_config.hpp as unnecessary #144

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Remove gil_config.hpp as unnecessary #144

merged 1 commit into from
Sep 27, 2018

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Sep 27, 2018 •
edited
Loading

Move BOOST_GIL_CONFIG_HAS_UNALIGNED_ACCESS define setting and documentation comment to channel.hpp where solely used.

Trim trailing whitespaces.

Tasklist

  • Review
  • All CI builds and checks have passed

@mloskot
Remove gil_config.hpp as unnecessary
c3bb2e1 
Move BOOST_GIL_CONFIG_HAS_UNALIGNED_ACCESS define setting and
documentation comment to channel.hpp where solely used.

Trim trailing whitespaces.
stefanseefeld
stefanseefeld approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@stefanseefeld stefanseefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removing dead code. :-)

chhenning
chhenning approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@chhenning chhenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah!

@mloskot mloskot merged commit fe0113e into boostorg:develop Sep 27, 2018
@mloskot
Copy link
Member Author

mloskot commented Sep 27, 2018

Thank you guys

@mloskot mloskot deleted the ml/remove-gil-config-header branch September 27, 2018 18:13
@mloskot mloskot added this to the Boost 1.69 milestone Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseefeld stefanseefeld stefanseefeld approved these changes

@chhenning chhenning chhenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Boost 1.69
Development

Successfully merging this pull request may close these issues.
3 participants
@mloskot @stefanseefeld @chhenning