Harris response computation #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simmplecoder
changed the title
mloskot
requested changes
Jul 23, 2019
There was a problem hiding this comment.
@simmplecoder I've taken the liberty of requesting a few clarifications and cleanups
mloskot
approved these changes
Jul 25, 2019
|
@stefanseefeld , if you don't have any more suggestions, could you please approve the PR? Last commit introduced license and copyright notices. Design PR will come as a different PR. |
This is a fresh start of branch Harris with manual copying and placement of code from previous versions
Weights passed as arguments were not used prior to this commit
Mostly moving brackets and adding const, but also address MSVC's max macro
In file numeric.hpp, there is full qualification, but harris.hpp didn't have full qualification, thus full qualification is added to harris.hpp
stefanseefeld
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Harris corner detection, but without suggested result filtering. The algorithm writes Harris responses into
gray32_view_tand the user can apply their chosen filtering/suppression algorithms. Loosening filtering will give edge detector.Environment
Everything compatible with Boost 1.70
References
https://en.wikipedia.org/wiki/Harris_Corner_Detector
https://en.wikipedia.org/wiki/Structure_tensor
https://en.wikipedia.org/wiki/Image_derivatives
http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.434.4816&rep=rep1&type=pdf
Tasklist
Write docs that would be readable for most peopleWill be covered by another PR.