Add implementatin of box filter and blur #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
changed the title
box_filter
mloskot
previously approved these changes
Aug 18, 2019
mloskot
dismissed
their stale review
There is an important build configuration missing
mloskot
requested changes
Aug 18, 2019
There was a problem hiding this comment.
run box_filter.cpp ; entry is missing from here:
gil/test/core/image_processing/Jamfile
Line 17 in ec30419
Currently, the box_filter.cpp test is not compiled on Jamfile-only CI jobs on Travis CI and AppVeyor.
mloskot
reviewed
Aug 18, 2019
mloskot
reviewed
Aug 18, 2019
mloskot
reviewed
Aug 18, 2019
mloskot
reviewed
Aug 18, 2019
miralshah365
force-pushed
the
box_filter
branch
from
ec30419
to
baebe52
Compare
mloskot
requested changes
Aug 18, 2019
There was a problem hiding this comment.
@miralshah365 There is one request for change to fix the test linking error
miralshah365
force-pushed
the
box_filter
branch
from
baebe52
to
f1118e2
Compare
mloskot
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
@miralshah365 looks good, feel free to merge.
Looks like you'll need to resolve conflict
implemented `blur` function tests added for `box_filter` closes boostorg#382
miralshah365
force-pushed
the
box_filter
branch
from
f1118e2
to
27d9d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implemented
blurfunctiontests added for
box_filterThis utility will provide a way to remove noise from the image using convolution with
averagekernel(normalized and unnormalized).It also provides
blurfunction which works only with normalized mean kernelsReferences
closes #382
Tasklist