-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Boost.Variant with Boost.Variant2 #474
Conversation
2fc5fe1
to
a2abb4b
Compare
Thanks, I'm very much in favour of switching to the Boost.Variant2 |
a2abb4b
to
c30304e
Compare
Builds fine with MSVC 2019. |
@pdimov Any chance that this issue that seems to be specific to MSVC 2017 rings a bell?
|
My guess is that it doesn't like
either because it doesn't like |
Hm no, it's actually this line:
The second |
Since the result of And maybe use b2 instead of cmake in order to see the errors.
|
|
I see that you already had the right thing there but commented out. :-) |
Thank you so much for your help, I am always amazed by the support you get from this community. Why on earth did I add this If I understand correctly, |
d7fab23
to
52a53ca
Compare
It only fails when you're inside the definition of |
418e05d
to
4bb5973
Compare
One of the Azure jobs failed with:
Any chance that it could be restarted? |
@sdebionne Restarted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for contributions! For me, it's ready to merge. Let's give others a day or two to review.
I think we could also get rid of this bridge now
gil/include/boost/gil/detail/mp11.hpp
Line 13 in a7a2cb2
#include <boost/mp11/mpl.hpp> // required by dynamic_image and boost::variant (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great improvement to the dynamic_image
extension.
I'm a bit wary, though, seeing that all our I/O extensions (and more !) depend on that. Wouldn't there be a way to split this, so someone can use the PNG
reader without having to drag in boost/variant2.hpp
, say ?
Currently, those all drag in |
OK, that's a fair point. So let's move forward with this PR, and try to separate the |
@stefanseefeld Yes, I think this PR is completed now and feasibility of decoupling the |
* develop: Collect release notes for Boost 1.74 Fix missing header in numeric/kernel.hpp to make it self-contained (#502) Use perfect forwading from apply_operation to visit (#491) Fix typos and replace mpl with mp11 in tutorial (#494) Implemented mechanism to reverse kernel_2d (#489) added missing const& in extend_boundary parameters (#490) Add initializing image constructor (#486) Fix interleaved_view factory using point<std::ptrdiff_t> for dimension (#487) RELEASES.md: Remove beta tag [ci skip] Replace Boost.Variant with Boost.Variant2 (#474) Fix error plane_view_t is not a class or namespace name (#481) Fix image constructor from other image (#477) Fix overflow in RGB to CMYK32 conversion (#470)
Description
Implements dynamic extension with Boost.Variant2 instead of Boost.Variant.
References
Fixes #232
Tasklist