Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove Windows Server 2016 from builds on Azure Pipelines #652

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Apr 26, 2022

Description

The images with Windows Server 2016 / Visual Studio 2017 have
been deprecated by Microsoft and are in the process of being
removed completely, so that no further builds with that image
will be possible.

I've just encountered the problem in #651
where the VS 2017 / Windows 2016 builds refused to start:

https://dev.azure.com/boostorg/gil/_build/results?buildId=1813&view=results

References

For reference, see

Since it seems that Microsoft is basically using the same build
environments on both Azure and GitHub Actions when it comes to
Windows and Visual Studio, I decided to remove those jobs instead
of updating them to a newer version of the image. The tests that
would be possible with newer images on Azure are basically what
we are already doing with GitHub Actions here.

Looks like the new final deadline for removal of Windows 2016 is
30th June 2022. But until that happens there will be several
"brownouts" lasting 24 hours each where users will see error
messages that indicate the image will be removed soon. This
basically means we cannot rely on Windows 2016 anymore, even
before 30th June.

Tasklist

  • Ensure all CI builds pass
  • Review and approve

The images with Windows Server 2016 / Visual Studio 2017 have
been deprecated by Microsoft and are in the process of being
removed completely, so that no further builds with that image
will be possible.

For reference, see
* <https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/>
* <actions/runner-images#5238>

Since it seems that Microsoft is basically using the same build
environments on both Azure and GitHub Actions when it comes to
Windows and Visual Studio, I decided to remove those jobs instead
of updating them to a newer version of the image. The tests that
would be possible with newer images on Azure are basically what
we are already doing with GitHub Actions.
@gene-keys
Copy link

IMPORTANT NOTE FOR THOSE OF YOU STILL STRUGGLING WITH WIN2016 BROWNOUT NOTICE.

CHECK EVERYTHING!

NOT JUST YOUR PIPELINE CODE, CHECK PIPELINE TRIGGERS POOLS. CHECK RELEASES POOLS, CHECK ALL THE POOLS EVERYWHERE ON YOUR DEVOPS ACCOUNT. WHAT WILL HAPPEN IS YOU WILL EVENTUALLY FIND SOMETHING STILL SET TO USE WIN2016 POOL. ONCE YOU FIND ALL OF THEM YOUR ACCOUNT WILL NO LONGER GET THE BROWNOUT NOTICE EVEN DURING THE SCHEDULED TIMES. SO IF YOU ARE GETTING THE NOTICE ITS NOT YOUR WIN2017 POOL, OR WIN-LATEST IN THE YML, ITS SOMETHING ELSE,

AZURE NOTICES ARE DOING A TERRIBLE JOB ON THIS WITH THEIR WORDING AND WHERE THE NOTICE APPEARS. THE NOTICE MEANS YOUR AZURE DEVOPS ACCOUNT IS STILL USING WINDWOS POOL SOMEWHERE, YOU DID NOT CHECK EVEYWHERE.

@mloskot
Copy link
Member

mloskot commented Apr 26, 2022

AFAICT, nothing uses Win 2016 pools anywhere under https://dev.azure.com/boostorg where GIL's CI happen on AzP.
So, I think we're good.

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mloskot mloskot merged commit 9ed8fd2 into boostorg:develop Apr 26, 2022
@striezel striezel deleted the ci-update-azure-pipelines branch April 26, 2022 19:21
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants