Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "main" field to package.json so the module can work with Browserify #373

Closed
Mavann1988 opened this issue Jan 9, 2015 · 2 comments
Closed

Add "main" field to package.json so the module can work with Browserify #373

Mavann1988 opened this issue Jan 9, 2015 · 2 comments
Assignees
@makeusabrew
Milestone
4.4.0

Comments

@Mavann1988
Copy link

Right now this module doesn't work with browserify. https://github.com/substack/browserify-handbook#how-node_modules-works

Since there is no "main" field, browserify cannot resolve the path correctly. By adding "main: 'bootbox.js'" to the package.json file it will fix this issue.
@makeusabrew makeusabrew self-assigned this Jan 9, 2015
@liam-swinney liam-swinney mentioned this issue Jan 30, 2015
Merged
makeusabrew added a commit that referenced this issue Feb 4, 2015
@makeusabrew
Merge pull request #384 from liam-swinney/addingMaintoPackageJSON
b0289f6 
Fix for Issue #373 - no main field
@makeusabrew
Copy link
Collaborator

Will be part of 4.4.0 (#300)

@makeusabrew makeusabrew modified the milestone: 4.4.0 Feb 17, 2015
@makeusabrew
Copy link
Collaborator

4.4.0 now available & on npm :)

@Raffaello Raffaello mentioned this issue Jul 17, 2015
Closed
sumityadav pushed a commit to sumityadav/bootbox that referenced this issue Feb 1, 2018
@liam-swinney
Fix for Issue bootboxjs#373 - no main field
43dd257
sumityadav pushed a commit to sumityadav/bootbox that referenced this issue Feb 1, 2018
@makeusabrew
Merge pull request bootboxjs#384 from liam-swinney/addingMaintoPackag…
1afacc2 
…eJSON

Fix for Issue bootboxjs#373 - no main field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makeusabrew makeusabrew

Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

No branches or pull requests
2 participants
@makeusabrew @Mavann1988