Added Arabic locale #425
Merged
Added Arabic locale #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arabic - ( ISO 639-1 : ar ) more: http://en.wikipedia.org/wiki/Arabic_language
|
Sorry, I just realized that I need to include some tests too, according to the contributing guidelines. Is there any example that I can follow to do the required tests? |
|
Tests are fairly easy to add for locales, eg. https://github.com/makeusabrew/bootbox/blob/master/tests/locales.test.coffee#L367-L378 Add new tests and then you can run those on your own computer to make sure that everything works. |
|
@tarlepp Thanks for explanation. Now I have included the required tests. |
|
@EmadOmar thanks for this! |
|
Thanks folks! |
sumityadav
pushed a commit
to sumityadav/bootbox
that referenced
this pull request
Feb 1, 2018
Added Arabic locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arabic - ( ISO 639-1 : ar )
more: http://en.wikipedia.org/wiki/Arabic_language