Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to source link #31

Merged
merged 9 commits into from
Feb 6, 2023
Merged

Revert to source link #31

merged 9 commits into from
Feb 6, 2023

Conversation

borkdude
Copy link
Owner

@borkdude borkdude commented Feb 6, 2023

No description provided.

@borkdude borkdude merged commit 4ec275a into main Feb 6, 2023
@borkdude
Copy link
Owner Author

borkdude commented Feb 6, 2023 •
edited
Loading

@helins I reverted the source icon to a <sub> again. I had doubts about the source icon myself for a while, I found it too big and drawing too much attention to itself. After asking I second opinion I got:

the source link is way better
I have no clue what the icon means before I click on it, plus it's big

If you still want to preserve the icon, we could make this an option or so.

@borkdude borkdude deleted the revert-to-source-link branch February 6, 2023 10:32
@helins
Copy link
Contributor

helins commented Feb 6, 2023

Good to know, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borkdude @helins