Use region specific endpoint when updating s3 hostname #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue when using govcloud regions, as `s3.amazonaws.com` won't map to the govcloud region. All botocore/awscli unit/integ tests pass
|
I'm not sure about this anymore. Maybe we should just fix a list of regions for which we don't rewrite the hostname. Otherwise you'll get the permanent redirect if you use the wrong region. |
|
Yeah, I've been looking at this fix and it makes it impossible to use the DNS resolution to redirect you to the right region rather than knowing the endpoint explicitly. I think we need to think of s3.amazonaws.com as being the universal endpoint for for all standard regions. But for special regions like govcloud we need to know that they don't use the universal endpoint. Or maybe we think of it as the special region having it's own, unique universal endpoint. |
Fixes an issue when using the govcloud region for s3.
|
Ok, PR updated, please review again. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when using govcloud regions, as
s3.amazonaws.comwon'tmap to the govcloud region.
All botocore/awscli unit/integ tests pass