Add retry and timeout as params to retrieving metadata service #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default has been changed to 1, which is now consistent with boto and other AWS SDKs.
Note that this does not plumb anything into the session via config vars. I think that should be a separate pull request.
| @@ -310,7 +310,7 @@ def set_credentials(self, access_key, secret_key, token=None): | |||
| token) | |||
| self._credentials.method = 'explicit' | |||
|
|
|||
| def get_credentials(self, metadata=None): | |||
There was a problem hiding this comment.
Do we need to worry about back-compat here (from removing a parameter)? Would anyone else be calling this or is it (hopefully) largely just internal?
There was a problem hiding this comment.
Internal, especially given the "This is mainly used for unit testing." in the docstring.
There was a problem hiding this comment.
My bad, I didn't read the whole docstring you were removing. Shipit stands.
|
LGTM otherwise. |
|
Would definitely like to see these pulled out as config vars but I'm fine with doing that as a separate PR. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198.
I did not add any config vars to the session to set these default values. However, I think it makes sense to add this (similar to how you can set these values in a boto config file). I'd like to send that as a separate pull request.
This only updates the low level metadata retrieval code so that it can be parameterized the number of retries and the connection timeouts.