win32: Do not define strcasecmp if defined #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears late builds of mingw-w64 already define strcasecmp and
strncasecmp appropriately, leading to errors of the form below when
cross compiling. This commit only redefines them if they have not
previously been defined.
In file included from
/vagrant/deps/libsigar/sigar/src/sigar_util.c:25:0:
/vagrant/deps/libsigar/sigar/include/sigar_private.h:120:0: warning:
"strcasecmp" redefined [enabled by default]
#define strcasecmp stricmp
^
In file included from /usr/share/mingw-w64/include/io.h:10:0,
from /usr/share/mingw-w64/include/fcntl.h:8,
from /vagrant/deps/libsigar/sigar/src/sigar_util.c:21:
/usr/share/mingw-w64/include/string.h:106:0: note: this is the location
of the previous definition
#define strcasecmp _stricmp
^
In file included from
/vagrant/deps/libsigar/sigar/src/sigar_util.c:25:0:
/vagrant/deps/libsigar/sigar/include/sigar_private.h:121:0: warning:
"strncasecmp" redefined [enabled by default]
#define strncasecmp strnicmp
^
In file included from /usr/share/mingw-w64/include/io.h:10:0,
from /usr/share/mingw-w64/include/fcntl.h:8,
from /vagrant/deps/libsigar/sigar/src/sigar_util.c:21:
/usr/share/mingw-w64/include/string.h:105:0: note: this is the location
of the previous definition
#define strncasecmp _strnicmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears late builds of mingw-w64 already define strcasecmp and
strncasecmp appropriately, leading to errors of the form below when
cross compiling. This commit only redefines them if they have not
previously been defined.