Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer main & output information from the composer.json #127

Merged
merged 3 commits into from
Apr 20, 2018

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Apr 20, 2018

Closes #117

  • Use the composer.json#bin setting to guess the main script file when none is provided
  • Strip the main path of its extension and append the .phar extension for the output when none is provided

BC break changes:

  • Change the default PHAR output from default.phar to index.phar
  • When no configuration is provided or when the setting main is omitted, the value found in composer.json#bin will have the priority over the default index.php
  • When no configuraiton is provided or when the setting output is omitted, the default value will depend in the input value as opposed to systematically default.phar

Closes box-project#117

- Use the `composer.json#bin` setting to guess the main script file when none is provided
- Strip the main path of its extension and append the `.phar` extension for the output when none is
  provided

BC break changes:
- Change the default PHAR output from `default.phar` to `index.phar`
- When no configuration is provided or when the setting `main` is omitted, the value found in
  `composer.json#bin` will have the priority over the default `index.php`
- When no configuraiton is provided or when the setting `output` is omitted, the default value will
  depend in the `input` value as opposed to systematically `default.phar`
@theofidry theofidry merged commit 69d6e8f into box-project:master Apr 20, 2018
@theofidry theofidry deleted the feature/composer-info branch April 20, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant