Requirement checker optimisations #195
Conversation
theofidry
commented
May 3, 2018
theofidry
commented
- Add compactors to compress the PHP and JSON code
- Fix the licenses (Closes Add back licenses to the requirement checker #192)
- Bump the requirement checker on the library to ship Allow the application to be run only from the CLI #185
- Add compactors to compress the PHP and JSON code - Fix the licenses (Closes box-project#192) - Bump the requirement checker on the library to ship box-project#185
theofidry
force-pushed
the
bugfix/requirement-checker
branch
from
69b91c6
to
6df63bf
Compare
| @@ -18,9 +18,10 @@ | |||
| use Traversable; | |||
|
|
|||
| /** | |||
| * The code in this file must be PHP 5.3+ compatible as is used to know if the application can be run. | |||
There was a problem hiding this comment.
it does no longer need to be compatible with 5.3 ?
There was a problem hiding this comment.
It is but this applies to the whole requirement-checker component and it is specified in the composer.json: https://github.com/humbug/box/tree/master/requirement-checker
| * @private | ||
| * @see \Symfony\Requirements\RequirementCollection | ||
| * @package symfony/requirements-checker | ||
| * @license MIT (c) Fabien Potencier <fabien@symfony.com> |
There was a problem hiding this comment.
from the license file
https://github.com/symfony/requirements-checker/blob/master/LICENSE
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
There was a problem hiding this comment.
The same way the license mention in the file points to the original LICENSE file, I'm referring to it there unless you consider it is not obvious enough and should also include the mention This source file is subject to the MIT license that is bundled with this source code in the file LICENSE. adjusted for this case.
But including the whole LICENSE file seems 1. overkill, 2. pollutes a lot the file and 3. really confusing as the file is not a 100% match with the original content.
There is an exception though as https://github.com/humbug/box/blob/master/requirement-checker/src/Terminal.php#L11 is a 100% match modulo some CS changes, I need to exclude the license change from PHP-CS-Fixer for this file.
