Allow dumping requirements from the composer.json file #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no dependencies Composer does not generate a `composer.lock` and as a result the requirement checker could not be generated. This patch now allows to use the requirement checker even in that situation. Note however that this implies the requirement checker could be wrong if one has a `composer.json` with dependencies but the `composer.lock` file went missing for some reasons. This is however and edge case that I don't think Box should worry about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no dependencies Composer does not generate a
composer.lockand as a result therequirement checker could not be generated. This patch now allows to use the requirement checker
even in that situation.
Note however that this implies the requirement checker could be wrong if one has a
composer.jsonwith dependencies but the
composer.lockfile went missing for some reasons. This is however andedge case that I don't think Box should worry about.