Dump the complete requirement checker #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that some classes for `.requirement-checker/src` had a prefix but the ones from `.requirement-checker/vendor`. This issue went unnoticed in the CI because when running `make test` the `.requirement-checker` is actually redumped (even though it should not). Makefile being a bit silly here, `.requirement-checker` is now dumped by a make command and no longer dumped during the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that some classes for
.requirement-checker/srchad a prefix but the ones from.requirement-checker/vendor.This issue went unnoticed in the CI because when running
make testthe.requirement-checkerisactually redumped (even though it should not).
Makefile being a bit silly here,
.requirement-checkeris now dumped by a make command and nolonger dumped during the tests