Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the replacement settings #245

Merged
merged 4 commits into from
May 31, 2018

Conversation

theofidry
Copy link
Member

  • Add documentation and tests for the replacement map
  • Deprecate the setting datetime_format in favour of the new setting datetime-format
  • [BC break] The datetime value used for the datetime placeholder is now always in UTC
  • [BC break] The settings datetime-format and datetime_format are now always evaluated even if the datetime setting is not used or null
  • [BC break] The settings datetime-format and datetime_format now throw an exception when the format is invalid

@theofidry theofidry merged commit d697bf0 into box-project:master May 31, 2018
@theofidry theofidry deleted the bugfix/placeholders branch May 31, 2018 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant