Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework default values #251

Merged
merged 1 commit into from
May 31, 2018
Merged

Conversation

theofidry
Copy link
Member

  • Make all settings optionals and nullable
  • When a setting is set to null then its default value is picked. It is strictly equivalent to omit the field
  • [BC break] Disabling the shebang requires to set shebang to false instead of null
  • [BC break] Disabling the banner requires to set banner to false instead of null

@theofidry theofidry merged commit e831cb5 into box-project:master May 31, 2018
@theofidry theofidry deleted the bugfix/default-values branch May 31, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant