Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the requirement checker Terminal getenv() usage #999

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented May 30, 2023

Same as #994 but updating the terminal diff to fix the CI.

Closes #994.

@jaapio
Copy link

jaapio commented Jun 7, 2023

Hi,

Is there anything I can do to help you move forward with this fix? I'm currently facing this error in the phpDocumentor pipelines, which kind of blocks me from releasing a new version.

So I would be very happy to help you solving this issue to unblock my own work.

Thanks for your amazing work, ❤️ I hope to hear from you soon.

@theofidry theofidry merged commit bee6dd7 into box-project:main Oct 6, 2023
64 of 65 checks passed
@theofidry theofidry deleted the fix-typeerror-terminal-env branch October 6, 2023 14:14
@theofidry
Copy link
Member Author

Thank you @danepowell for the fix and @mlocati for the report.

Sorry it took so long, slowly getting back to things. I'll release this ASAP. I can't really say a date though but Box is back to my priority list.

/cc @jaapio @nunomaduro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants